Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibWeb: Select element will not trigger onchange when using element.value #1522

Merged
merged 1 commit into from
Oct 8, 2024
Merged

LibWeb: Select element will not trigger onchange when using element.value #1522

merged 1 commit into from
Oct 8, 2024

Conversation

Arhcout
Copy link
Contributor

@Arhcout Arhcout commented Sep 25, 2024

Fix #1493

@Arhcout Arhcout marked this pull request as ready for review September 25, 2024 09:00
@gmta
Copy link
Collaborator

gmta commented Sep 25, 2024

Could you please add a test that exposes the issue and prevents a regression?

@Arhcout
Copy link
Contributor Author

Arhcout commented Sep 25, 2024

Absolutely!

@Arhcout Arhcout changed the title LibJS: Select element will not trigger onchange when using element.value LibWeb: Select element will not trigger onchange when using element.value Sep 25, 2024
@Arhcout
Copy link
Contributor Author

Arhcout commented Oct 2, 2024

The new test is done sorry for the time it took

@Arhcout
Copy link
Contributor Author

Arhcout commented Oct 2, 2024 •
edited
Loading

The pull request still says "Changes requested" How do I fix it?

@awesomekling awesomekling merged commit 5d00211 into LadybirdBrowser:master Oct 8, 2024
6 checks passed
@Arhcout Arhcout deleted the fix_1493 branch October 8, 2024 17:06
@nico nico mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmta gmta gmta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Site continuously reloading
3 participants
@Arhcout @gmta @awesomekling